572879 - Narcissus JS shell

Status: RESOLVED FIXED

(Other Applications Graveyard :: Narcissus, defect)

Description

[Tom Austin]

Currently, there is no shell for Narcissus, which would be useful for integrating with jstests.py (and possibly other tools).

Comment 1

[Tom Austin]

Attachment: Patch for narcissus shell to use with jstests.py

This patch allows narcissus to be used from the command line and integrate with the jstests.py setup.

Comment 2

[Tom Austin]

Attachment: Some tweaks to the testing setup

This patch removes an unnecessary file + updates testing instructions accordingly.  Also, adds a few new tests to narcFailuresFull.txt.

Comment 3

[Tom Austin]

Attachment: Work around for lack of special 'evaluate' method.

The shell currently relies on js.js being able to load the other files.  This patch will instead load the other js files directly (and not bother with js.js).

Comment 4

[Andreas Gal :gal]

Comment on attachment 452937 [details] [diff] [review]
Patch for narcissus shell to use with jstests.py

>-    print: print, version: null
>+    print: print //, version: null

function() { return 185; } or whatever the JS engine does.

>+++ b/js/src/tests/narcFailures.txt	Mon Jun 21 17:25:43 2010 -0700

This ain't DOS. We can call it narcissusFailures.txt :)

I am ok with the list but we should work through this to shorten it.

Comment 5

[Andreas Gal :gal]

Comment on attachment 454093 [details] [diff] [review]
Work around for lack of special 'evaluate' method.

nshell maybe?

Comment 6

[Brendan Eich [:brendan]]

narcissus-failures.txt please -- no shift RSI, consistent with earlier failures file names.

nshell is no good -- njs?

/be

Comment 7

[Andreas Gal :gal]

yeah, njs sounds pretty good.

Comment 8

[Andreas Gal :gal]

Same here. Please do the changes I pointed out and the ones brendan remarked and then push the patch citing the bug # and me as reviewer.

Comment 9

[Tom Austin]

Changeset:  http://hg.mozilla.org/tracemonkey/rev/566555927784

Comment 10

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/566555927784